lkml.org 
[lkml]   [2020]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 3/7] proc: Mov rcu_read_(lock|unlock) in proc_prune_siblings_dcache
    On Thu, Feb 20, 2020 at 12:51 PM Eric W. Biederman
    <ebiederm@xmission.com> wrote:
    >
    > Don't make it look like rcu_read_lock is held over the entire loop
    > instead just take the rcu_read_lock over the part of the loop that
    > matters. This makes the intent of the code a little clearer.

    No, this is horrid.

    Maybe it makes the intent clearer, but it also causes that "continue"
    case to unlock and relock immediately.

    And maybe that case never triggers, and that's ok. But then it needs a
    big comment about it.

    Linus

    \
     
     \ /
      Last update: 2020-02-20 23:34    [W:7.604 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site