Messages in this thread Patch in this message |  | | From | Dmitry Osipenko <> | Subject | [PATCH v7 12/19] dmaengine: tegra-apb: Remove handling of unrealistic error condition | Date | Mon, 3 Feb 2020 01:28:47 +0300 |
| |
The pending_sg_req list can't ever be empty because:
1. If it was empty, then handle_cont_sngl_cycle_dma_done() shall crash before of handle_continuous_head_request() invocation.
2. The handle_cont_sngl_cycle_dma_done() can't happen after stopping DMA.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/dma/tegra20-apb-dma.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index 62d181bd5e62..c7dc27ef1856 100644 --- a/drivers/dma/tegra20-apb-dma.c +++ b/drivers/dma/tegra20-apb-dma.c @@ -564,12 +564,6 @@ static bool handle_continuous_head_request(struct tegra_dma_channel *tdc, { struct tegra_dma_sg_req *hsgreq; - if (list_empty(&tdc->pending_sg_req)) { - dev_err(tdc2dev(tdc), "DMA is running without req\n"); - tegra_dma_stop(tdc); - return false; - } - /* * Check that head req on list should be in flight. * If it is not in flight then abort transfer as -- 2.24.0
|  |