[lkml]   [2020]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] hugetlb: Remove check_coalesce_bug debug code
On 2/19/20 3:36 PM, Mina Almasry wrote:
> Commit b5f16a533ce8a ("hugetlb: support file_region coalescing
> again") made changes to the resv_map code which are hard to test, it
> so added debug code guarded by CONFIG_DEBUG_VM which conducts an
> expensive operation that loops over the resv_map and checks it for
> errors.
> Unfortunately, some distros have CONFIG_DEBUG_VM on in their default
> kernels, and we don't want this debug code behind CONFIG_DEBUG_VM
> and called each time a file region is added. This patch removes this
> debug code. I may look into making it a test or leave it for my local
> testing.
> Signed-off-by: Mina Almasry <>
> Cc: David Rientjes <>
> Cc: Mike Kravetz <>
> Cc: Shakeel Butt <>
> Cc: Andrew Morton <>
> Cc:
> Cc:
> Fixes: b5f16a533ce8a ("hugetlb: support file_region coalescing again")


Reviewed-by: Mike Kravetz <>

The review also applies to the original patch with the removal of
this code.
Mike Kravetz

 \ /
  Last update: 2020-02-20 01:08    [W:0.095 / U:0.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site