[lkml]   [2020]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 0/2] rewrite mtk-quadspi spi-nor driver with spi-mem

On Tue, Feb 18, 2020 at 8:55 PM Mark Brown <> wrote:
> This is an ABI break so you shouldn't be doing this, if the existing
> binding works it should continue to work.

The missing spi-max-frequency is the only part preventing old
device tree to work with this driver.
If the goal is to make existing dt binding work, I could patch dt using
of_add_property in v2. I saw similar device tree patching for legacy
bindings in pinctrl-single driver.

> > 3. removing the old driver. I'll create this commit after 1 and 2 are
> > applied to avoid possible rebasing due to any changes in the old
> > driver.
> This isn't great as it means we have a period with two drivers for the
> same thing in tree which is at best going to be confusing. There's no
> advantage to splitting this out.

Got it. I'll add this patch in v2.

Chuanhong Guo

 \ /
  Last update: 2020-02-20 00:58    [W:0.119 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site