lkml.org 
[lkml]   [2020]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 1/3] dt-bindings: clock: Add YAML schemas for the QCOM MSS clock bindings
From
Date
Thanks Stephen.
Will address the comments in the next patch series.

On 1/30/2020 11:36 PM, Stephen Boyd wrote:
> Quoting Taniya Das (2020-01-29 20:18:41)
>> The Modem Subsystem clock provider have a bunch of generic properties
>> that are needed in a device tree. Add a YAML schemas for those.
>>
>> Signed-off-by: Taniya Das <tdas@codeaurora.org>
>> ---
>> .../devicetree/bindings/clock/qcom,mss.yaml | 58 ++++++++++++++++++++++
>
> Please rename to qcom,sc7180-mss.yaml
>
>> 1 file changed, 58 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/qcom,mss.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,mss.yaml b/Documentation/devicetree/bindings/clock/qcom,mss.yaml
>> new file mode 100644
>> index 0000000..ebb04e1
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,mss.yaml
>> @@ -0,0 +1,58 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/bindings/clock/qcom,mss.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Modem Clock Controller Binding
>> +
>> +maintainers:
>> + - Taniya Das <tdas@codeaurora.org>
>> +
>> +description: |
>> + Qualcomm modem clock control module which supports the clocks.
>
> Can you point to the header file from here?
> include/dt-bindings/clock/qcom,sc7180-mss.h I guess.
>

will add the same.

>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - qcom,sc7180-mss
>> +
>> + clocks:
>> + minItems: 1
>> + maxItems: 3
>
> Why is it optional? Don't these all go there?
>

Yes, moved them to required.

>> + items:
>> + - description: gcc_mss_mfab_axi clock from GCC
>> + - description: gcc_mss_nav_axi clock from GCC
>> + - description: gcc_mss_cfg_ahb clock from GCC
>> +
>> + clock-names:
>> + items:
>> + - const: gcc_mss_mfab_axis_clk
>> + - const: gcc_mss_nav_axi_clk
>> + - const: cfg_clk
>
> Do these really need _clk at the end? Seems redundant.
>
Removed _clk.

>> +
>> + '#clock-cells':
>> + const: 1
>> +

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--

\
 
 \ /
  Last update: 2020-02-18 19:14    [W:0.169 / U:2.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site