lkml.org 
[lkml]   [2020]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/8] perf annotate/config: More fixes
From
Date


On 2/17/20 2:45 AM, Jiri Olsa wrote:
> On Thu, Feb 13, 2020 at 12:12:58PM +0530, Ravi Bangoria wrote:
>> These are the additional set of fixes on top of previous series:
>> http://lore.kernel.org/r/20200204045233.474937-1-ravi.bangoria@linux.ibm.com
>>
>> Note for the last patch:
>> I couldn't understand what intel-pt.cache-divisor is really used for.
>> Adrian, can you please help.
>>
>> Ravi Bangoria (8):
>> perf annotate/tui: Re-render title bar after switching back from
>> script browser
>> perf annotate: Fix --show-total-period for tui/stdio2
>> perf annotate: Fix --show-nr-samples for tui/stdio2
>> perf config: Introduce perf_config_u8()
>> perf annotate: Make perf config effective
>> perf annotate: Prefer cmdline option over default config
>> perf annotate: Fix perf config option description
>> perf config: Document missing config options
>
> nice, I guess this all worked in the past but got broken because
> we don't have any tests for annotation code.. any chance you could
> think of some way to test annotations?
>
> perhaps some shell script, or prepare all the needed data for annotation
> manualy.. sort of like we did in tests/hists_*.c

Sure Jiri. I'll take a look at this.

Ravi

\
 
 \ /
  Last update: 2020-02-17 14:02    [W:0.108 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site