lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.5 074/542] drm/nouveau/nouveau: fix incorrect sizeof on args.src an args.dst
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit f42e4b337b327b1336c978c4b5174990a25f68a0 ]

    The sizeof is currently on args.src and args.dst and should be on
    *args.src and *args.dst. Fortunately these sizes just so happen
    to be the same size so it worked, however, this should be fixed
    and it also cleans up static analysis warnings

    Addresses-Coverity: ("sizeof not portable")
    Fixes: f268307ec7c7 ("nouveau: simplify nouveau_dmem_migrate_vma")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/nouveau/nouveau_dmem.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/nouveau/nouveau_dmem.c b/drivers/gpu/drm/nouveau/nouveau_dmem.c
    index fa14399415965..0ad5d87b5a8e5 100644
    --- a/drivers/gpu/drm/nouveau/nouveau_dmem.c
    +++ b/drivers/gpu/drm/nouveau/nouveau_dmem.c
    @@ -635,10 +635,10 @@ nouveau_dmem_migrate_vma(struct nouveau_drm *drm,
    unsigned long c, i;
    int ret = -ENOMEM;

    - args.src = kcalloc(max, sizeof(args.src), GFP_KERNEL);
    + args.src = kcalloc(max, sizeof(*args.src), GFP_KERNEL);
    if (!args.src)
    goto out;
    - args.dst = kcalloc(max, sizeof(args.dst), GFP_KERNEL);
    + args.dst = kcalloc(max, sizeof(*args.dst), GFP_KERNEL);
    if (!args.dst)
    goto out_free_src;

    --
    2.20.1
    \
     
     \ /
      Last update: 2020-02-14 19:19    [W:2.164 / U:6.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site