lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.5 383/542] gpio: Fix the no return statement warning
    Date
    From: Kevin Hao <haokexin@gmail.com>

    [ Upstream commit 9c6722d85e92233082da2b3623685bba54d6093e ]

    In commit 242587616710 ("gpiolib: Add support for the irqdomain which
    doesn't use irq_fwspec as arg") we have changed the return type of
    gpiochip_populate_parent_fwspec_twocell/fourcell() from void to void *,
    but forgot to add a return statement for these two dummy functions.
    Add "return NULL" to fix the build warnings.

    Reported-by: kbuild test robot <lkp@intel.com>
    Signed-off-by: Kevin Hao <haokexin@gmail.com>
    Link: https://lore.kernel.org/r/20200116095003.30324-1-haokexin@gmail.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    include/linux/gpio/driver.h | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
    index e2480ef94c559..5dce9c67a961e 100644
    --- a/include/linux/gpio/driver.h
    +++ b/include/linux/gpio/driver.h
    @@ -553,6 +553,7 @@ static inline void gpiochip_populate_parent_fwspec_twocell(struct gpio_chip *chi
    unsigned int parent_hwirq,
    unsigned int parent_type)
    {
    + return NULL;
    }

    static inline void gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *chip,
    @@ -560,6 +561,7 @@ static inline void gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *ch
    unsigned int parent_hwirq,
    unsigned int parent_type)
    {
    + return NULL;
    }

    #endif /* CONFIG_IRQ_DOMAIN_HIERARCHY */
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-02-14 18:58    [W:2.060 / U:0.456 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site