lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.4 038/100] tty: omap-serial: remove set but unused variable
    Date
    From: Xiongfeng Wang <wangxiongfeng2@huawei.com>

    [ Upstream commit e83c6587c47caa2278aa3bd603b5a85eddc4cec9 ]

    Fix the following warning:
    drivers/tty/serial/omap-serial.c: In function serial_omap_rlsi:
    drivers/tty/serial/omap-serial.c:496:16: warning: variable ch set but not used [-Wunused-but-set-variable]

    The character read is useless according to the table 23-246 of the omap4
    TRM. So we can drop it.

    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
    Link: https://lore.kernel.org/r/1575617863-32484-1-git-send-email-wangxiongfeng2@huawei.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/tty/serial/omap-serial.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
    index 21fc9b3a27cfa..debd2c93ca3c9 100644
    --- a/drivers/tty/serial/omap-serial.c
    +++ b/drivers/tty/serial/omap-serial.c
    @@ -497,10 +497,13 @@ static unsigned int check_modem_status(struct uart_omap_port *up)
    static void serial_omap_rlsi(struct uart_omap_port *up, unsigned int lsr)
    {
    unsigned int flag;
    - unsigned char ch = 0;

    + /*
    + * Read one data character out to avoid stalling the receiver according
    + * to the table 23-246 of the omap4 TRM.
    + */
    if (likely(lsr & UART_LSR_DR))
    - ch = serial_in(up, UART_RX);
    + serial_in(up, UART_RX);

    up->port.icount.rx++;
    flag = TTY_NORMAL;
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-02-14 17:34    [W:3.483 / U:0.924 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site