lkml.org 
[lkml]   [2020]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 4/6] hwrng: imx-rngc - (trivial) simplify error prints
On Tue, 28 Jan 2020 at 16:31, Martin Kaiser <martin@kaiser.cx> wrote:
>
> Remove the device name, it is added by the dev_...() routines.
>
> Drop the error code as well. It will be shown by the driver core when
> the probe operation failed.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/char/hw_random/imx-rngc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
> index 1381ddd5b891..8222055b9e9b 100644
> --- a/drivers/char/hw_random/imx-rngc.c
> +++ b/drivers/char/hw_random/imx-rngc.c
> @@ -258,14 +258,14 @@ static int imx_rngc_probe(struct platform_device *pdev)
> if (self_test) {
> ret = imx_rngc_self_test(rngc);
> if (ret) {
> - dev_err(rngc->dev, "FSL RNGC self test failed.\n");
> + dev_err(rngc->dev, "self test failed\n");
> goto err;
> }
> }
>
> ret = devm_hwrng_register(&pdev->dev, &rngc->rng);
> if (ret) {
> - dev_err(&pdev->dev, "FSL RNGC registering failed (%d)\n", ret);
> + dev_err(&pdev->dev, "hwrng registration failed\n");
> goto err;
> }
>
> --
> 2.20.1
>

Reviewed-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>

\
 
 \ /
  Last update: 2020-02-12 17:24    [W:0.165 / U:2.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site