lkml.org 
[lkml]   [2020]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] remoteproc: fix kernel-doc warnings
From
Date
Hi Randy

On 2/12/20 4:54 PM, Randy Dunlap wrote:
> Hi,
>
> kernel-doc supports "..." as a function argument for varargs.
> See Documentation/doc-guide/kernel-doc.rst:
>
> "If a function has a variable number of arguments, its description should
> be written in kernel-doc notation as::
>
> * @...: description"
I missed it, thanks for pointing it out!

Regards
Arnaud
>
>
> So the below could be done as:
>
> On 2/12/20 1:32 AM, Arnaud Pouliquen wrote:
>> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
>> index 097f33e4f1f3..5f9a5812505c 100644
>> --- a/drivers/remoteproc/remoteproc_core.c
>> +++ b/drivers/remoteproc/remoteproc_core.c
>> @@ -224,7 +224,7 @@ EXPORT_SYMBOL(rproc_da_to_va);
>> /**
>> * rproc_find_carveout_by_name() - lookup the carveout region by a name
>> * @rproc: handle of a remote processor
>> - * @name,..: carveout name to find (standard printf format)
>> + * @name: carveout name to find (standard printf format)
>
> * @name: carveout name to find
> * @...: standard printf format of args to search for carveout name
>
> although I'm not so sure about the descriptions there.
>
>> *
>> * Platform driver has the capability to register some pre-allacoted carveout
>> * (physically contiguous memory regions) before rproc firmware loading and
>
>
> thanks for the kernel-doc update.
>

\
 
 \ /
  Last update: 2020-02-12 17:02    [W:0.791 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site