lkml.org 
[lkml]   [2020]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/8] x86,tracing: Mark debug_stack_{set_zero,reset)() notrace
On Wed, Feb 12, 2020 at 10:18:26AM -0500, Steven Rostedt wrote:
> On Wed, 12 Feb 2020 16:04:40 +0100
> Peter Zijlstra <peterz@infradead.org> wrote:
>
> > > This entire file is notrace:
> > >
> > > arch/x86/kernel/cpu/Makefile:
> > >
> > > CFLAGS_REMOVE_common.o = -pg
> >
> > Urgh, I hate it that that annotation is so hard to find :/ Also, there
> > seem to be various flavours of that Makefile magic around.
> >
> > CFLAGS_REMOVE_lockdep.o = $(CC_FLAGS_FTRACE)
> >
> > is another variant I encountered.
>
> Actually, that should be the only variant. That was added for various
> archs, and should be used consistently throughout.
>
> There's a clean up series for you ;-) (or whoever)

If I'm going to clean this up I'd remove the Makefile rules entirely.
I hate these Makefile rules, they make it entirely non-obvious what is
and is not being traced.

\
 
 \ /
  Last update: 2020-02-12 16:40    [W:0.104 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site