lkml.org 
[lkml]   [2020]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 25/62] x86/head/64: Install boot GDT
On Tue, Feb 11, 2020 at 02:29:24PM -0800, Andy Lutomirski wrote:
> On Tue, Feb 11, 2020 at 5:53 AM Joerg Roedel <joro@8bytes.org> wrote:
> > + /* GDT loaded - switch to __KERNEL_CS so IRET works reliably */
> > + pushq $__KERNEL_CS
> > + leaq .Lon_kernel_cs(%rip), %rax
> > + pushq %rax
> > + lretq
> > +
> > +.Lon_kernel_cs:
> > + UNWIND_HINT_EMPTY
>
> I would suggest fixing at least SS as well.

You are right, that is cleaner. Initialized DS, ES, and SS to
__KERNEL_DS here too.

Regards,

Joerg

\
 
 \ /
  Last update: 2020-02-12 13:21    [W:0.134 / U:3.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site