Messages in this thread |  | | Subject | Re: [PATCH] ARM: dts: sun5i: Add dts for inet86v_rev2 | From | Alexandre GRIVEAUX <> | Date | Wed, 12 Feb 2020 10:45:03 +0100 |
| |
Le 11/02/2020 à 14:15, Maxime Ripard a écrit : > On Mon, Feb 10, 2020 at 11:35:52AM +0100, agriveaux@deutnet.info wrote: >> From: Alexandre GRIVEAUX <agriveaux@deutnet.info> >> >> Add Inet 86V Rev 2 support, based upon Inet 86VS. >> >> Missing things: >> - Accelerometer (MXC6225X) >> - Touchpanel (Sitronix SL1536) >> - Nand (29F32G08CBACA) >> - Camera (HCWY0308) >> >> Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info> > Please read the documentation I sent you yesterday. In particular, > when submitting multiple versions, you should remove have the version > number in the title and a changelog. > > Also, please ask questions if you're unsure about something, or > discuss something you do not agree with instead of ignoring the > comment. > > Maxime
Hello,
Seem I misusing 'git send-email' because i already changed the subject line (same apply to u-boot):
git send-email --from agriveaux@deutnet.info --to robh+dt@kernel.org,mark.rutland@arm.com,mripard@kernel.org,wens@csie.org --cc linux-kernel@vger.kernel.org,devicetree@vger.kernel.org,agriveaux@deutnet.info --subject '[v2] ARM: dts: sun5i: Add dts for inet86v_rev2' --compose /tmp/linux/0001-ARM-dts-sun5i-Add-dts-for-inet86v_rev2.patch
It's the first time i use git send-email, previously i used mutt to send patchsets (on mips mostly).
Effectively i've forgot the changelog...
At why do we need another device tree:
inet86vs use a GSL1680 touchpanel controller and 4GB nand [0]
inet86vsuse a Sitonix SL1536 touchpanel controller and 8GB nand (can have 16GB nand)[1]
Seem i've forgot to use:
git format-patch --subject-prefix="PATCH v2"
Thanks.
[0]https://fccid.io/2AARJ-AP7S118/Schematics/Schematics-2042312.pdfinet86vs schematic
[1]https://fccid.io/XHW026/Schematics/Schematics-1820577.pdfinet86v schematic
|  |