lkml.org 
[lkml]   [2020]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] asm-generic: Fix unistd_32.h generation format
On Wed, Feb 12, 2020 at 1:16 AM Michal Simek <michal.simek@xilinx.com> wrote:
>
> Generated files are also checked by sparse that's why add newline
> to remove sparse (C=1) warning.
>
> The issue was found on Microblaze and reported like this:
> ./arch/microblaze/include/generated/uapi/asm/unistd_32.h:438:45:
> warning: no newline at end of file
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Reviewed-by: Stefan Asserhall <stefan.asserhall@xilinx.com>
> ---
>
> Changes in v2:
> - Update also others archs not just microblaze - Arnd
> - Align subject and description to match multiarch chagne
>
> arch/alpha/kernel/syscalls/syscallhdr.sh | 1 +
> arch/ia64/kernel/syscalls/syscallhdr.sh | 1 +
> arch/m68k/kernel/syscalls/syscallhdr.sh | 1 +
> arch/microblaze/kernel/syscalls/syscallhdr.sh | 1 +
> arch/parisc/kernel/syscalls/syscallhdr.sh | 1 +
> arch/sh/kernel/syscalls/syscallhdr.sh | 1 +
> arch/sparc/kernel/syscalls/syscallhdr.sh | 1 +
> arch/xtensa/kernel/syscalls/syscallhdr.sh | 1 +
> 8 files changed, 8 insertions(+)

For xtensa:
Acked-by: Max Filippov <jcmvbkbc@gmail.com>

...

> diff --git a/arch/m68k/kernel/syscalls/syscallhdr.sh b/arch/m68k/kernel/syscalls/syscallhdr.sh
> index 6f357d68ef44..8ac15be01ac2 100644
> --- a/arch/m68k/kernel/syscalls/syscallhdr.sh
> +++ b/arch/m68k/kernel/syscalls/syscallhdr.sh
> @@ -33,4 +33,5 @@ grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | (
> printf "#endif\n"
> printf "\n"
> printf "#endif /* %s */\n" "${fileguard}"

Here there's already \n at the end, so no need for another one?

> + printf "\n"
> ) > "$out"

...

--
Thanks.
-- Max

\
 
 \ /
  Last update: 2020-02-12 10:24    [W:0.144 / U:2.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site