lkml.org 
[lkml]   [2020]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 0/3] IMA: improve log messages in IMA
From
Date


On 2020-02-12 7:23 a.m., Mimi Zohar wrote:
> Hi Tushar,
>
> "in IMA" is redundant in the above Subject line.
>
Thanks Mimi. I will fix it in the next iteration.

> On Tue, 2020-02-11 at 15:14 -0800, Tushar Sugandhi wrote:
>> Some files under IMA prefix the log statement with the respective file
>> names and not with the string "ima". This is not consistent with the rest
>> of the IMA files.
>>
>> The function process_buffer_measurement() does not have log messages for
>> failure conditions.
>>
>> The #define for formatting log messages, pr_fmt, is duplicated in the
>> files under security/integrity.
>>
>> This patchset addresses the above issues.
>
> The cover letter should provide a summary of the problem(s) being
> addressed by the individual patches, not a repetition of the
> individual patch descriptions.
>
Thanks. I will fix the cover letter description in the next iteration.

> Mimi
>
>>
>> Tushar Sugandhi (3):
>> add log prefix to ima_mok.c, ima_asymmetric_keys.c, ima_queue_keys.c
>> add log message to process_buffer_measurement failure conditions
>> add module name and base name prefix to log statements
>>
>> security/integrity/digsig.c | 2 --
>> security/integrity/digsig_asymmetric.c | 2 --
>> security/integrity/evm/evm_crypto.c | 2 --
>> security/integrity/evm/evm_main.c | 2 --
>> security/integrity/evm/evm_secfs.c | 2 --
>> security/integrity/ima/Makefile | 6 +++---
>> security/integrity/ima/ima_asymmetric_keys.c | 2 --
>> security/integrity/ima/ima_crypto.c | 2 --
>> security/integrity/ima/ima_fs.c | 2 --
>> security/integrity/ima/ima_init.c | 2 --
>> security/integrity/ima/ima_kexec.c | 1 -
>> security/integrity/ima/ima_main.c | 5 +++--
>> security/integrity/ima/ima_policy.c | 2 --
>> security/integrity/ima/ima_queue.c | 2 --
>> security/integrity/ima/ima_queue_keys.c | 2 --
>> security/integrity/ima/ima_template.c | 2 --
>> security/integrity/ima/ima_template_lib.c | 2 --
>> security/integrity/integrity.h | 6 ++++++
>> 18 files changed, 12 insertions(+), 34 deletions(-)
>>

\
 
 \ /
  Last update: 2020-02-12 23:23    [W:0.113 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site