lkml.org 
[lkml]   [2020]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 2/2] fpga: dfl: fme: add performance reporting support
On Wed, Feb 12, 2020 at 11:19:29AM +0800, Wu Hao wrote:
> On Mon, Feb 10, 2020 at 04:34:01PM +0000, Will Deacon wrote:
> > Hi,
> >
> > On Mon, Feb 10, 2020 at 11:47:49AM +0800, Wu Hao wrote:
> > > This patch adds support for performance reporting private feature
> > > for FPGA Management Engine (FME). Now it supports several different
> > > performance counters, including 'basic', 'cache', 'fabric', 'vtd'
> > > and 'vtd_sip'. It allows user to use standard linux tools to access
> > > these performance counters.
> >
> > I had a quick look at this, and it mostly looks alright to me. Just a few
> > high-level comments/questions:
>
> Hi Will
>
> Thanks a lot for the review! :)
>
> >
> > - I would still prefer for the PMU drivers to live under drivers/perf/
>
> Hm.. one possible way is to create a platform device, and introduce a new
> platform device driver under drivers/perf/.

No, do not abuse platform drivers, you have a real device, use it.

\
 
 \ /
  Last update: 2020-02-12 06:31    [W:0.113 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site