lkml.org 
[lkml]   [2020]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] workqueue: don't use wq_select_unbound_cpu() for bound works
On Fri, Jan 24, 2020 at 08:14:45PM -0500, Daniel Jordan wrote:
> From: Hillf Danton <hdanton@sina.com>
>
> wq_select_unbound_cpu() is designed for unbound workqueues only, but
> it's wrongly called when using a bound workqueue too.
>
> Fixing this ensures work queued to a bound workqueue with
> cpu=WORK_CPU_UNBOUND always runs on the local CPU.
>
> Before, that would happen only if wq_unbound_cpumask happened to include
> it (likely almost always the case), or was empty, or we got lucky with
> forced round-robin placement. So restricting
> /sys/devices/virtual/workqueue/cpumask to a small subset of a machine's
> CPUs would cause some bound work items to run unexpectedly there.
>
> Fixes: ef557180447f ("workqueue: schedule WORK_CPU_UNBOUND work on wq_unbound_cpumask CPUs")
> Signed-off-by: Hillf Danton <hdanton@sina.com>
> [dj: massage changelog]
> Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Lai Jiangshan <jiangshanlai@gmail.com>
> Cc: linux-kernel@vger.kernel.org

Applied to wq/for-5.6-fixes.

Thanks.

--
tejun

\
 
 \ /
  Last update: 2020-02-12 22:08    [W:0.047 / U:0.972 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site