lkml.org 
[lkml]   [2020]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 3/4] platform/chrome: typec: Get PD_CONTROL cmd version
From
Date
Hi Prashant,

On 7/2/20 21:37, Prashant Malani wrote:
> Query the EC to determine the version number of the PD_CONTROL
> command which is supported by the EC. Also store this value in the Type
> C data struct since it will be used to determine how to parse the
> response to queries for port information from the EC.
>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> ---
>
> Changes in v2:
> - No changes.
>
> drivers/platform/chrome/cros_ec_typec.c | 34 ++++++++++++++++++++++++-
> 1 file changed, 33 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 8374ccfe784f3b..df01ce86c7146c 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -21,6 +21,7 @@ struct cros_typec_data {
> struct device *dev;
> struct cros_ec_device *ec;
> int num_ports;
> + unsigned int cmd_ver;
> /* Array of ports, indexed by port number. */
> struct typec_port *ports[EC_USB_PD_MAX_PORTS];
> };
> @@ -152,6 +153,31 @@ static int cros_typec_ec_command(struct cros_typec_data *typec,
> return ret;
> }
>
> +static int cros_typec_get_cmd_version(struct cros_typec_data *typec)
> +{
> + struct ec_params_get_cmd_versions_v1 req_v1;
> + struct ec_response_get_cmd_versions resp;
> + int ret;
> +
> + /* We're interested in the PD control command version. */
> + req_v1.cmd = EC_CMD_USB_PD_CONTROL;
> + ret = cros_typec_ec_command(typec, 1, EC_CMD_GET_CMD_VERSIONS,
> + &req_v1, sizeof(req_v1), &resp,
> + sizeof(resp));
> + if (ret < 0)
> + return ret;
> +
> + if (resp.version_mask & EC_VER_MASK(1))
> + typec->cmd_ver = 1;
> + else
> + typec->cmd_ver = 0;
> +
> + dev_dbg(typec->dev, "PD Control has version mask 0x%hhx\n",
> + typec->cmd_ver);
> +
> + return 0;
> +}
> +
> #ifdef CONFIG_ACPI
> static const struct acpi_device_id cros_typec_acpi_id[] = {
> { "GOOG0014", 0 },
> @@ -182,6 +208,12 @@ static int cros_typec_probe(struct platform_device *pdev)
> typec->ec = dev_get_drvdata(pdev->dev.parent);
> platform_set_drvdata(pdev, typec);
>
> + ret = cros_typec_get_cmd_version(typec);
> + if (ret < 0) {
> + dev_err(dev, "failed to get PD command version info\n");
> + return ret;
> + }
> +
> ret = cros_typec_ec_command(typec, 0, EC_CMD_USB_PD_PORTS, NULL, 0,
> &resp, sizeof(resp));
> if (ret < 0)
> @@ -196,7 +228,7 @@ static int cros_typec_probe(struct platform_device *pdev)
> }
>
> ret = cros_typec_init_ports(typec);
> - if (!ret)
> + if (ret < 0)

Looks like this change should be in patch 2/4?

> return ret;
>
> return 0;
>

\
 
 \ /
  Last update: 2020-02-11 11:53    [W:0.126 / U:5.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site