lkml.org 
[lkml]   [2020]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.5 009/367] bnxt_en: Fix TC queue mapping.
    Date
    From: Michael Chan <michael.chan@broadcom.com>

    [ Upstream commit 18e4960c18f484ac288f41b43d0e6c4c88e6ea78 ]

    The driver currently only calls netdev_set_tc_queue when the number of
    TCs is greater than 1. Instead, the comparison should be greater than
    or equal to 1. Even with 1 TC, we need to set the queue mapping.

    This bug can cause warnings when the number of TCs is changed back to 1.

    Fixes: 7809592d3e2e ("bnxt_en: Enable MSIX early in bnxt_init_one().")
    Signed-off-by: Michael Chan <michael.chan@broadcom.com>
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    @@ -7892,7 +7892,7 @@ static void bnxt_setup_msix(struct bnxt
    int tcs, i;

    tcs = netdev_get_num_tc(dev);
    - if (tcs > 1) {
    + if (tcs) {
    int i, off, count;

    for (i = 0; i < tcs; i++) {

    \
     
     \ /
      Last update: 2020-02-10 14:09    [W:11.530 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site