lkml.org 
[lkml]   [2020]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.5 085/367] powerpc/xmon: dont access ASDR in VMs
    Date
    From: Sukadev Bhattiprolu <sukadev@linux.ibm.com>

    commit c2a20711fc181e7f22ee5c16c28cb9578af84729 upstream.

    ASDR is HV-privileged and must only be accessed in HV-mode.
    Fixes a Program Check (0x700) when xmon in a VM dumps SPRs.

    Fixes: d1e1b351f50f ("powerpc/xmon: Add ISA v3.0 SPRs to SPR dump")
    Cc: stable@vger.kernel.org # v4.14+
    Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
    Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20200107021633.GB29843@us.ibm.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/powerpc/xmon/xmon.c | 9 ++++-----
    1 file changed, 4 insertions(+), 5 deletions(-)

    --- a/arch/powerpc/xmon/xmon.c
    +++ b/arch/powerpc/xmon/xmon.c
    @@ -1949,15 +1949,14 @@ static void dump_300_sprs(void)

    printf("pidr = %.16lx tidr = %.16lx\n",
    mfspr(SPRN_PID), mfspr(SPRN_TIDR));
    - printf("asdr = %.16lx psscr = %.16lx\n",
    - mfspr(SPRN_ASDR), hv ? mfspr(SPRN_PSSCR)
    - : mfspr(SPRN_PSSCR_PR));
    + printf("psscr = %.16lx\n",
    + hv ? mfspr(SPRN_PSSCR) : mfspr(SPRN_PSSCR_PR));

    if (!hv)
    return;

    - printf("ptcr = %.16lx\n",
    - mfspr(SPRN_PTCR));
    + printf("ptcr = %.16lx asdr = %.16lx\n",
    + mfspr(SPRN_PTCR), mfspr(SPRN_ASDR));
    #endif
    }


    \
     
     \ /
      Last update: 2020-02-10 14:07    [W:5.881 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site