[lkml]   [2020]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 5.5 311/367] mfd: bd70528: Fix hour register mask
    From: Matti Vaittinen <>

    commit 6c883472e1c11cb05561b6dd0c28bb037c2bf2de upstream.

    When RTC is used in 24H mode (and it is by this driver) the maximum
    hour value is 24 in BCD. This occupies bits [5:0] - which means
    correct mask for HOUR register is 0x3f not 0x1f. Fix the mask

    Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")

    Signed-off-by: Matti Vaittinen <>
    Acked-by: Alexandre Belloni <>
    Signed-off-by: Lee Jones <>
    Signed-off-by: Greg Kroah-Hartman <>

    include/linux/mfd/rohm-bd70528.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/include/linux/mfd/rohm-bd70528.h
    +++ b/include/linux/mfd/rohm-bd70528.h
    @@ -317,7 +317,7 @@ enum {
    #define BD70528_MASK_RTC_MINUTE 0x7f
    #define BD70528_MASK_RTC_HOUR_24H 0x80
    #define BD70528_MASK_RTC_HOUR_PM 0x20
    -#define BD70528_MASK_RTC_HOUR 0x1f
    +#define BD70528_MASK_RTC_HOUR 0x3f
    #define BD70528_MASK_RTC_DAY 0x3f
    #define BD70528_MASK_RTC_WEEK 0x07
    #define BD70528_MASK_RTC_MONTH 0x1f

     \ /
      Last update: 2020-02-10 13:56    [W:4.248 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site