lkml.org 
[lkml]   [2020]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.5 326/367] net/mlx5: IPsec, Fix esp modify function attribute
    Date
    From: Raed Salem <raeds@mellanox.com>

    [ Upstream commit 0dc2c534f17c05bed0622b37a744bc38b48ca88a ]

    The function mlx5_fpga_esp_validate_xfrm_attrs is wrongly used
    with negative negation as zero value indicates success but it
    used as failure return value instead.

    Fix by remove the unary not negation operator.

    Fixes: 05564d0ae075 ("net/mlx5: Add flow-steering commands for FPGA IPSec implementation")
    Signed-off-by: Raed Salem <raeds@mellanox.com>
    Reviewed-by: Boris Pismenny <borisp@mellanox.com>
    Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c
    @@ -1478,7 +1478,7 @@ int mlx5_fpga_esp_modify_xfrm(struct mlx
    if (!memcmp(&xfrm->attrs, attrs, sizeof(xfrm->attrs)))
    return 0;

    - if (!mlx5_fpga_esp_validate_xfrm_attrs(mdev, attrs)) {
    + if (mlx5_fpga_esp_validate_xfrm_attrs(mdev, attrs)) {
    mlx5_core_warn(mdev, "Tried to create an esp with unsupported attrs\n");
    return -EOPNOTSUPP;
    }

    \
     
     \ /
      Last update: 2020-02-10 13:49    [W:4.113 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site