lkml.org 
[lkml]   [2020]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.5 090/367] PCI: tegra: Fix return value check of pm_runtime_get_sync()
    Date
    From: David Engraf <david.engraf@sysgo.com>

    commit 885199148442f56b880995d703d2ed03b6481a3c upstream.

    pm_runtime_get_sync() returns the device's usage counter. This might
    be >0 if the device is already powered up or CONFIG_PM is disabled.

    Abort probe function on real error only.

    Fixes: da76ba50963b ("PCI: tegra: Add power management support")
    Link: https://lore.kernel.org/r/20191216111825.28136-1-david.engraf@sysgo.com
    Signed-off-by: David Engraf <david.engraf@sysgo.com>
    Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Acked-by: Andrew Murray <andrew.murray@arm.com>
    Cc: stable@vger.kernel.org # v4.17+
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/pci/controller/pci-tegra.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/pci/controller/pci-tegra.c
    +++ b/drivers/pci/controller/pci-tegra.c
    @@ -2798,7 +2798,7 @@ static int tegra_pcie_probe(struct platf

    pm_runtime_enable(pcie->dev);
    err = pm_runtime_get_sync(pcie->dev);
    - if (err) {
    + if (err < 0) {
    dev_err(dev, "fail to enable pcie controller: %d\n", err);
    goto teardown_msi;
    }

    \
     
     \ /
      Last update: 2020-02-10 13:44    [W:5.200 / U:0.704 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site