lkml.org 
[lkml]   [2020]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/6] dt-bindings: PCI: pci-ep: Add binding to specify virtual function
On Thu, Nov 12, 2020 at 11:23:53PM +0530, Kishon Vijay Abraham I wrote:
> Add binding to specify virtual function (associated with each physical
> function) in endpoint mode.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> Documentation/devicetree/bindings/pci/pci-ep.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/pci-ep.yaml b/Documentation/devicetree/bindings/pci/pci-ep.yaml
> index 7847bbcd4a03..90c85a0c44a1 100644
> --- a/Documentation/devicetree/bindings/pci/pci-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/pci-ep.yaml
> @@ -23,6 +23,15 @@ properties:
> default: 1
> maximum: 255
>
> + max-virtual-functions:
> + description: Maximum number of virtual functions that can be configured

Need to say what each element of the array corresponds to.

> + allOf:

Can drop 'allOf' here.

> + - $ref: /schemas/types.yaml#/definitions/uint8-array
> + minItems: 0

minItems should never be 0. That's no property present.

> + maxItems: 255
> + items:
> + maximum: 255
> +
> max-link-speed:
> $ref: /schemas/types.yaml#/definitions/uint32
> enum: [ 1, 2, 3, 4 ]
> --
> 2.17.1
>

\
 
 \ /
  Last update: 2020-12-07 19:57    [W:0.065 / U:6.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site