lkml.org 
[lkml]   [2020]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [f2fs-dev] [PATCH RESEND] f2fs: compress: deny setting unsupported compress algorithm
From
Date
On 2020/12/8 2:16, Eric Biggers wrote:
> On Mon, Dec 07, 2020 at 05:56:09PM +0800, Chao Yu wrote:
>> If kernel doesn't support certain kinds of compress algorithm, deny to set
>> them as compress algorithm of f2fs via 'compress_algorithm=%s' mount option.
>>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>> no changes, just rebase on dev branch.
>
> This doesn't apply to the dev branch anymore.

Maybe you apply patches with wrong order?

https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git/log/?h=dev

>
>> fs/f2fs/super.c | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index e0fe72f1d2c8..662e59f32645 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -936,9 +936,14 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
>> if (!name)
>> return -ENOMEM;
>> if (!strcmp(name, "lzo")) {
>> +#ifdef CONFIG_F2FS_FS_LZO
>> F2FS_OPTION(sbi).compress_algorithm =
>> COMPRESS_LZO;
>> +#else
>> + f2fs_info(sbi, "Image doesn't support lzo compression");
>> +#endif
>
> These info messages don't make sense. It's not the filesystem image that
> doesn't support the algorithm, but rather the kernel that doesn't.
>
> Also, shouldn't these be warnings instead of "info"?

Correct.

>
> - Eric
> .
>

\
 
 \ /
  Last update: 2020-12-08 02:12    [W:0.068 / U:1.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site