lkml.org 
[lkml]   [2020]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/5] crypto: hisilicon/sec - add new type of sqe for Kunpeng930
From
Date

On 2020/12/4 15:03, Herbert Xu Wrote:
> On Thu, Nov 26, 2020 at 10:18:03AM +0800, Longfang Liu wrote:
>>
>> diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.h b/drivers/crypto/hisilicon/sec2/sec_crypto.h
>> index 0e933e7..712176b 100644
>> --- a/drivers/crypto/hisilicon/sec2/sec_crypto.h
>> +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.h
>> @@ -211,6 +219,167 @@ struct sec_sqe {
>> struct sec_sqe_type2 type2;
>> };
>>
>> +#pragma pack(4)
>
> Please don't use pragma pack. Instead add the attributes as
> needed to each struct or member.
>
> Cheers,
>
Can I use __attribute__((aligned(n))) instead of #pragma pack(n)?
Thanks,
Longfang.

\
 
 \ /
  Last update: 2020-12-07 04:46    [W:0.052 / U:6.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site