lkml.org 
[lkml]   [2020]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 07/16] completion: drop init_completion define
On Tue, Dec 01, 2020 at 03:03:01PM +0100, Mauro Carvalho Chehab wrote:

> [PATCH] completion: drop init_completion define
>
> Changeset cd8084f91c02 ("locking/lockdep: Apply crossrelease to completions")
> added a CONFIG_LOCKDEP_COMPLETE (that was later renamed to
> CONFIG_LOCKDEP_COMPLETIONS).
>
> Such changeset renamed the init_completion, and add a macro
> that would either run a modified version or the original code.
>
> However, such code reported too many false positives. So, it
> ended being dropped later on by
> changeset e966eaeeb623 ("locking/lockdep: Remove the cross-release locking checks").
>
> Yet, the define remained there as just:
>
> #define init_completion(x) __init_completion(x)
>
> Get rid of the define, and return __init_completion() function
> to its original name.
>
> Fixes: e966eaeeb623 ("locking/lockdep: Remove the cross-release locking checks")

Thanks! should show up in tip/locking/core soonish..

> diff --git a/include/linux/completion.h b/include/linux/completion.h
> index bf8e77001f18..51d9ab079629 100644
> --- a/include/linux/completion.h
> +++ b/include/linux/completion.h
> @@ -28,8 +28,7 @@ struct completion {
> struct swait_queue_head wait;
> };
>
> -#define init_completion_map(x, m) __init_completion(x)
> -#define init_completion(x) __init_completion(x)
> +#define init_completion_map(x, m) init_completion(x)
> static inline void complete_acquire(struct completion *x) {}
> static inline void complete_release(struct completion *x) {}
>
> @@ -82,7 +81,7 @@ static inline void complete_release(struct completion *x) {}
> * This inline function will initialize a dynamically created completion
> * structure.
> */
> -static inline void __init_completion(struct completion *x)
> +static inline void init_completion(struct completion *x)
> {
> x->done = 0;
> init_swait_queue_head(&x->wait);
>

\
 
 \ /
  Last update: 2020-12-02 09:15    [W:0.076 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site