[lkml]   [2020]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

> On Dec 16, 2020, at 5:23 PM, Michał Mirosław <> wrote:
> On Wed, Dec 16, 2020 at 10:07:38PM +0000, Nick Terrell wrote:
> [...]
>> It is very large. If it helps, in the commit message I’ve provided this link [0],
>> which provides the diff between upstream zstd as-is and the imported zstd,
>> which has been modified by the automated tooling to work in the kernel.
>> [0]
> I looks like you could remove a bit more dead code by noting __GNUC__ >= 4
> (gcc-4.9 is currently the oldest supported [1]).

Yeah, that would certainly be possible. My goal was to remove the most egregiously
irrelevant code from the kernel, in addition to unused functions which would generate
-Wframe-larger-than compiler warnings. My tooling doesn’t have the logic to reason
about >= relationships yet. If it isn’t too hard to add, I may go ahead and do that,
otherwise I will leave it for future work. I view that as a “nice to have” instead of a
hard requirement, though let me know if you disagree.


> [1] Documentation/process/changes.rst
> Best Regards
> Michał Mirosław

 \ /
  Last update: 2020-12-18 20:00    [W:0.111 / U:3.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site