Messages in this thread |  | | Date | Thu, 5 Nov 2020 18:10:51 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH v1 1/1] ARM: dts: sun8i: h3: Add initial NanoPi R1 support |
| |
On Wed, Nov 04, 2020 at 04:07:48PM +0800, Yu-Tung Chang wrote: > > > +&uart1 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&uart1_pins>; > > > > This should be already set in the DTSI > > > uart0 as the debugging interface, uart1 as the external uart port, > uart3 as the bluetooth.
What I mean is that since it's the only muxing option, the pinctrl properties should already be set in the DTSI, so it's redundant to put them in the DTS.
Maxime [unhandled content-type:application/pgp-signature] |  |