lkml.org 
[lkml]   [2020]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 2/7] fpga: sec-mgr: enable secure updates
From
Date
Hi Russ,

I found another thing while testing this...

On 06/11/2020 02.09, Russ Weight wrote:

<snip>

> +static ssize_t filename_store(struct device *dev, struct device_attribute *attr,
> + const char *buf, size_t count)
> +{
> + struct fpga_sec_mgr *smgr = to_sec_mgr(dev);
> + int ret = count;
> +
> + if (count == 0 || count >= PATH_MAX)
> + return -EINVAL;
> +
> + mutex_lock(&smgr->lock);
> + if (smgr->driver_unload || smgr->progress != FPGA_SEC_PROG_IDLE) {
> + ret = -EBUSY;
> + goto unlock_exit;
> + }
> +
> + smgr->filename = kstrndup(buf, count - 1, GFP_KERNEL);

The `count - 1` is meant to remove a trailing newline, but opae-sdk
writes the filename without newline, so better do it conditionally...

> + if (!smgr->filename) {
> + ret = -ENOMEM;
> + goto unlock_exit;
> + }
> +
> + smgr->err_code = FPGA_SEC_ERR_NONE;
> + smgr->progress = FPGA_SEC_PROG_READING;
> + reinit_completion(&smgr->update_done);
> + schedule_work(&smgr->work);
> +
> +unlock_exit:
> + mutex_unlock(&smgr->lock);
> + return ret;
> +}
> +static DEVICE_ATTR_WO(filename);
> +
> +static struct attribute *sec_mgr_update_attrs[] = {
> + &dev_attr_filename.attr,
> + NULL,
> +};

Thanks,
Martin

\
 
 \ /
  Last update: 2020-11-26 15:03    [W:0.104 / U:11.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site