lkml.org 
[lkml]   [2020]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4] fs/aio.c: Cosmetic
From
Date
Hi Randy,

Thanks for the review.
Next time I'll do it in two parts, as you wished.

Thanks,

Alex

On 11/21/20 2:22 AM, Randy Dunlap wrote:
> On 11/20/20 2:06 PM, Alejandro Colomar wrote:
>> Changes:
>> - Consistently use 'unsigned int', instead of 'unsigned'.
>> - Add a blank line after variable declarations.
>> - Move variable declarations to the top of functions.
>> - Invert logic of 'if's to reduce indentation and simplify function logic.
>> - Add goto tags when needed.
>> - Early return when appropriate.
>> - Add braces to 'else' if the corresponding 'if' used braces.
>> - Replace spaces by tabs
>> - Add spaces when appropriate (after comma, around operators, ...).
>> - Split multiple assignments.
>> - Align function arguments.
>> - Fix typos in comments.
>> - s/%Lx/%llx/ Standard C uses 'll'.
>> - Remove trailing whitespace in comments.
>>
>> This patch does not introduce any actual changes in behavior.
>>
>> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
>> ---
>>
>> Hi,
>>
>> I rebased the patch on top of the current master,
>> to update it after recent changes to aio.c.
>>
>> Thanks,
>>
>> Alex
>>
>> fs/aio.c | 466 +++++++++++++++++++++++++++++--------------------------
>> 1 file changed, 243 insertions(+), 223 deletions(-)
>
> Hi,
> I reviewed this patch.
> I think it looks OK, but I wish that there was a better way to review it.
>
> I'm not asking you to redo the patch, but I think that it would have been easier
> to review 2 patches: one that contains trivial changes[1] and one that requires
> thinking to review it -- where the trivial changes are not getting in the way
> of looking at the non-trivial changes.
>
> [1] the trivial set of changes, taken from your patch description:
>
>> - Consistently use 'unsigned int', instead of 'unsigned'.
>> - Add a blank line after variable declarations.
>> - Move variable declarations to the top of functions.
>> - Add braces to 'else' if the corresponding 'if' used braces.
>> - Replace spaces by tabs
>> - Add spaces when appropriate (after comma, around operators, ...).
>> - Split multiple assignments.
>> - Align function arguments.
>> - Fix typos in comments.
>> - s/%Lx/%llx/ Standard C uses 'll'.
>> - Remove trailing whitespace in comments.
>
> OK, that's everything except for this:
>> - Invert logic of 'if's to reduce indentation and simplify function logic.
>> - Add goto tags when needed.
>> - Early return when appropriate.
>
>
> thanks.
>

\
 
 \ /
  Last update: 2020-11-21 12:42    [W:0.041 / U:4.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site