lkml.org 
[lkml]   [2020]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/4] iio: hid-sensor-trigger: Decrement runtime pm enable count on driver removal
On Thu, 19 Nov 2020 18:03:29 +0800
Ye Xiang <xiang.ye@intel.com> wrote:

> To avoid pm_runtime_disable called repeatedly by hid sensor drivers,
> decrease runtime pm enable count after call it.
>
> Signed-off-by: Ye Xiang <xiang.ye@intel.com>
This sounds like a fix. If so please make that clear and add a fixes tag.

If it couldn't have been triggered before, then please explain why in this
patch description.

Thanks,

Jonathan

> ---
> drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> index ff375790b7e8..30340abcbc8d 100644
> --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> @@ -227,8 +227,10 @@ static int hid_sensor_data_rdy_trigger_set_state(struct iio_trigger *trig,
> void hid_sensor_remove_trigger(struct iio_dev *indio_dev,
> struct hid_sensor_common *attrb)
> {
> - if (atomic_read(&attrb->runtime_pm_enable))
> + if (atomic_read(&attrb->runtime_pm_enable)) {
> pm_runtime_disable(&attrb->pdev->dev);
> + atomic_dec(&attrb->runtime_pm_enable);
> + }
>
> pm_runtime_set_suspended(&attrb->pdev->dev);
> pm_runtime_put_noidle(&attrb->pdev->dev);

\
 
 \ /
  Last update: 2020-11-21 18:24    [W:0.097 / U:5.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site