lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 17/17] ACPI: GED: fix -Wformat
    Date
    From: Nick Desaulniers <ndesaulniers@google.com>

    commit 9debfb81e7654fe7388a49f45bc4d789b94c1103 upstream.

    Clang is more aggressive about -Wformat warnings when the format flag
    specifies a type smaller than the parameter. It turns out that gsi is an
    int. Fixes:

    drivers/acpi/evged.c:105:48: warning: format specifies type 'unsigned
    char' but the argument has type 'unsigned int' [-Wformat]
    trigger == ACPI_EDGE_SENSITIVE ? 'E' : 'L', gsi);
    ^~~

    Link: https://github.com/ClangBuiltLinux/linux/issues/378
    Fixes: ea6f3af4c5e6 ("ACPI: GED: add support for _Exx / _Lxx handler methods")
    Acked-by: Ard Biesheuvel <ardb@kernel.org>
    Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/acpi/evged.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/acpi/evged.c
    +++ b/drivers/acpi/evged.c
    @@ -101,7 +101,7 @@ static acpi_status acpi_ged_request_inte

    switch (gsi) {
    case 0 ... 255:
    - sprintf(ev_name, "_%c%02hhX",
    + sprintf(ev_name, "_%c%02X",
    trigger == ACPI_EDGE_SENSITIVE ? 'E' : 'L', gsi);

    if (ACPI_SUCCESS(acpi_get_handle(handle, ev_name, &evt_handle)))

    \
     
     \ /
      Last update: 2020-11-20 12:10    [W:18.036 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site