lkml.org 
[lkml]   [2020]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] memstick: mspro_block: remove unneeded semicolon
From
Date

On 11/1/20 10:51 PM, kajoljain wrote:
>
> On 10/31/20 7:18 PM, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> A semicolon is not needed after a switch statement.
> Hi Tom,
> I was checking this patch. Not sure if it will come under as fix patch. Since this is not fixing
> any logical issue do we still need to add fix tag?

My rule of thumb is a fix means the kernel needs to be recompiled.

This isn't a fix.

Tom

>
> Thanks,
> Kajol Jain
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>> drivers/memstick/core/mspro_block.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c
>> index cd6b8d4f2335..afb892e7ffc6 100644
>> --- a/drivers/memstick/core/mspro_block.c
>> +++ b/drivers/memstick/core/mspro_block.c
>> @@ -276,7 +276,7 @@ static const char *mspro_block_attr_name(unsigned char tag)
>> return "attr_devinfo";
>> default:
>> return NULL;
>> - };
>> + }
>> }
>>
>> typedef ssize_t (*sysfs_show_t)(struct device *dev,
>>

\
 
 \ /
  Last update: 2020-11-02 14:44    [W:0.067 / U:9.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site