lkml.org 
[lkml]   [2020]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others
Hi Yifeng,

赵仪峰 <yifeng.zhao@rock-chips.com> wrote on Mon, 2 Nov 2020 16:14:01
+0800:

> Hi Miquel,
>
> The nand_base.c will call nand_deselect_target after NAND read/program... ops done, and set variable chip->cur_cs = -1,
> but the nand controller do nothing and the cs of the NAND device is still selected,
> so the NAND device  will not enter auto power save mode.

Yes, I need to think about it again.

What I am saying is that this has *nothing* to do with the controller
driver your are trying to merge. Please focus on the bare features.
Once these will be merged, it will be easier to propose changes on top
of it to bring more fine grained features.

It's v13 already, please focus on the controller's basic features,
implement them correctly and in a second time we'll think about the
power consumption, what do you think?

Thanks,
Miquèl

\
 
 \ /
  Last update: 2020-11-02 09:21    [W:0.042 / U:3.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site