lkml.org 
[lkml]   [2020]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: rtw88: fix fw_fifo_addr check
From
Date
trix@redhat.com wrote:

> From: Tom Rix <trix@redhat.com>
>
> The clang build reports this warning
>
> fw.c:1485:21: warning: address of array 'rtwdev->chip->fw_fifo_addr'
> will always evaluate to 'true'
> if (!rtwdev->chip->fw_fifo_addr) {
>
> fw_fifo_addr is an array in rtw_chip_info so it is always
> nonzero. A better check is if the first element of the array is
> nonzero. In the cases where fw_fifo_addr is initialized by rtw88b
> and rtw88c, the first array element is 0x780.
>
> Fixes: 0fbc2f0f34cc ("rtw88: add dump firmware fifo support")
> Signed-off-by: Tom Rix <trix@redhat.com>
> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> Acked-by: Tzu-En Huang <tehuang@realtek.com>

Patch applied to wireless-drivers.git, thanks.

ddcd945e556e rtw88: fix fw_fifo_addr check

--
https://patchwork.kernel.org/project/linux-wireless/patch/20201011155438.15892-1-trix@redhat.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

\
 
 \ /
  Last update: 2020-11-02 19:17    [W:0.068 / U:1.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site