lkml.org 
[lkml]   [2020]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 11/14] misc: bcm-vk: add BCM_VK_QSTATS
From
Date
Hi Florian,

On 2020-10-02 6:39 p.m., Florian Fainelli wrote:
>
>
> On 10/2/2020 2:23 PM, Scott Branden wrote:
>> Add BCM_VK_QSTATS Kconfig option to allow for enabling debug VK
>> queue statistics.
>>
>> These statistics keep track of max, abs_max, and average for the
>> messages queues.
>>
>> Co-developed-by: Desmond Yan <desmond.yan@broadcom.com>
>> Signed-off-by: Desmond Yan <desmond.yan@broadcom.com>
>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>
> would not it make more sense to have those debug prints be trace printks instead? Given what you explained in the previous patch version and the desire to correlate with other system wide activity, that might make more sense. Looking at the kernel's log for debugging performance or utilization or just to get a glimpse of what is going on is not quite suited past probe.
The debug prints have served our purpose up to this point.
But, in the interest of getting the other driver patches accepted I will drop this patch from the series and we will investigate further.

Thanks,
 Scott
[unhandled content-type:application/pkcs7-signature]
\
 
 \ /
  Last update: 2020-11-17 22:37    [W:0.058 / U:3.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site