lkml.org 
[lkml]   [2020]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] drivers: hv: vmbus: Fix unnecessary OOM_MESSAGE
On Sun, Nov 15, 2020 at 04:57:33PM -0300, Matheus Castello wrote:
> Fixed checkpatch warning: Possible unnecessary 'out of memory' message
> checkpatch(OOM_MESSAGE)
>
> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
> ---
> drivers/hv/vmbus_drv.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 09d8236a51cf..774b88dd0e15 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -1989,10 +1989,8 @@ struct hv_device *vmbus_device_create(const guid_t *type,
> struct hv_device *child_device_obj;
>
> child_device_obj = kzalloc(sizeof(struct hv_device), GFP_KERNEL);
> - if (!child_device_obj) {
> - pr_err("Unable to allocate device object for child device\n");
> + if (!child_device_obj)

The generic OOM message would give you a stack dump but not as specific
/ clear as the message you deleted.

Also, the original intent of this check was to check for things like

printk("Out of memory");

which was clearly redundant. The message we print here is not that.

See https://lkml.org/lkml/2014/6/10/382 .

Wei.

> return NULL;
> - }
>
> child_device_obj->channel = channel;
> guid_copy(&child_device_obj->dev_type, type);
> --
> 2.28.0
>

\
 
 \ /
  Last update: 2020-11-16 12:24    [W:0.123 / U:2.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site