[lkml]   [2020]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] perf/intel: Remove Perfmon-v4 counter_freezing support
Hi Peter,

On 2020/11/10 23:37, Peter Zijlstra wrote:
> -static int __init intel_perf_counter_freezing_setup(char *s)
> -{
> - bool res;
> -
> - if (kstrtobool(s, &res))
> - return -EINVAL;
> -
> - disable_counter_freezing = !res;
> - return 1;
> -}
> -__setup("perf_v4_pmi=", intel_perf_counter_freezing_setup);


> Anyway, as it stands I think the whole counter_freezing thing is a
> trainwreck and it needs to go.

If you really want to drop the counter_freezing stuff, we also need
to clean it up in Documentation/admin-guide/kernel-parameters.txt:

perf_v4_pmi= [X86,INTEL]
Format: <bool>
Disable Intel PMU counter freezing feature.
The feature only exists starting from
Arch Perfmon v4 (Skylake and newer).

However someone may still need it based on the correct understanding
of "Freeze-on-Overflow" as Stephane said. How about renaming and
documenting it instead of discarding it completely?

Our guest PEBS enabling patches does not completely depend on it
and we do not require the administrator to enable perf_v4_pmi for
guest PEBS.

Would you generously take a look at the perf part in this series?

Like Xu

 \ /
  Last update: 2020-11-16 04:23    [W:0.091 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site