lkml.org 
[lkml]   [2020]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv1 3/4] dt-bindings: fpga: add authenticate-fpga-config property
From
Date
Hi Tom,

On 11/13/20 2:28 PM, Tom Rix wrote:
>
> On 11/12/20 10:06 AM, richard.gong@linux.intel.com wrote:
>> From: Richard Gong <richard.gong@intel.com>
>>
>> Add authenticate-fpga-config property for FPGA bitstream authentication.
>>
>> Signed-off-by: Richard Gong <richard.gong@intel.com>
>> ---
>> Documentation/devicetree/bindings/fpga/fpga-region.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/fpga/fpga-region.txt b/Documentation/devicetree/bindings/fpga/fpga-region.txt
>> index e811cf8..7a512bc 100644
>> --- a/Documentation/devicetree/bindings/fpga/fpga-region.txt
>> +++ b/Documentation/devicetree/bindings/fpga/fpga-region.txt
>> @@ -187,6 +187,7 @@ Optional properties:
>> - external-fpga-config : boolean, set if the FPGA has already been configured
>> prior to OS boot up.
>> - encrypted-fpga-config : boolean, set if the bitstream is encrypted
>> +- authenticate-fpga-config : boolean, set if do bitstream authentication
>
> The list is mostly in alphabetical order so the new 'authenticate-... ' should go at the top.
>

The original list is not in alphabetical order. The order of
partial-fpga-config, external-fpga-config and encrypted-fpga-config here
follows the implementation in the of-fpga-region.c file.

So authenticate-fpga-config should follow the way, correct?

> Improve what you mean by 'authentication' similar to my comment in the first patch.
>

Will do in the version 2 submission.

Regards,
Richard

> Tom
>
>> - region-unfreeze-timeout-us : The maximum time in microseconds to wait for
>> bridges to successfully become enabled after the region has been
>> programmed.
>

\
 
 \ /
  Last update: 2020-11-14 15:32    [W:0.062 / U:2.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site