lkml.org 
[lkml]   [2020]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/12] samples: configfs: order includes alphabetically
On Thu, Oct 08, 2020 at 03:23:11PM +0200, Bartosz Golaszewski wrote:
> On Wed, Oct 7, 2020 at 3:43 PM Christoph Hellwig <hch@lst.de> wrote:
> >
> > On Thu, Sep 24, 2020 at 02:45:16PM +0200, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > >
> > > The preferred coding style is to order all includes alphabetically for
> > > improved readability. There's no need for the configfs header to come
> > > last.
> >
> > Is it? People seem to have all kinds of weird opinions, but I don't
> > think any ordering really makes sense. What does make sense it dropping
> > the pointless empty line, so I've folded that into the next patch.
>
> This is not just a baseless opinion, keeping headers sorted clearly
> has an advantage: you more easily avoid duplicating includes, you see
> right away if a header is already included or not. Many maintainers
> will require ordering in new patches.

Various maintainers required all kind of crap. I've not seen one
I deal with require alphabetic ordering, but I've seen the equally
insane reverse christmas tree.

> It's your call but it's better code with not much effort.

No, it is not in any quantifyable way better. It is different and you
might prefer that, but in the end change it is just churn.

\
 
 \ /
  Last update: 2020-10-08 16:06    [W:0.059 / U:2.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site