[lkml]   [2020]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 00/12] samples: configfs: refactor the configfs sample code
On Thu, Sep 24, 2020 at 2:45 PM Bartosz Golaszewski <> wrote:
> From: Bartosz Golaszewski <>
> Over at the GPIO sub-system we have a testing module (gpio-mockup) which
> uses module params to instantiate simulated GPIO chips and debugfs to
> control them. We want to switch to a more stable interface using configfs
> to instantiate chips and sysfs to control them.
> For that we need the feature that's well defined in the docs but currently
> unimplemented - committable items. I started working on this but it won't
> be ready for this release cycle.
> In the meantime I also refactored the configfs samples a bit as I'll be
> adding sample code for committable items. I thought that it won't hurt
> to send the refactoring patches now for v5.10 so here it is. No logical
> changes really, mostly just code quality and removing usage of deprecated
> functions.
> Bartosz Golaszewski (12):
> MAINTAINERS: add the sample directory to the configfs entry
> samples: configfs: order includes alphabetically
> samples: configfs: remove redundant newlines
> samples: configfs: drop unnecessary ternary operators
> samples: configfs: improve alignment of broken lines
> samples: configfs: fix alignment in item struct
> samples: configfs: replace simple_strtoul() with kstrtoint()
> samples: configfs: don't reinitialize variables which are already
> zeroed
> samples: configfs: prefer sizeof(*var) to sizeof(struct var_type)
> samples: configfs: consolidate local variables of the same type
> samples: configfs: don't use spaces before tabs
> samples: configfs: prefer pr_err() over bare printk(KERN_ERR
> samples/configfs/configfs_sample.c | 78 +++++++++++-------------------
> 2 files changed, 29 insertions(+), 50 deletions(-)
> --
> 2.17.1

Hi Joel, Christoph,

Any comments on this? Can this still go into v5.10?


 \ /
  Last update: 2020-10-06 12:40    [W:0.103 / U:3.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site