lkml.org 
[lkml]   [2020]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 4/5] dmaengine: idxd: Clean up descriptors with fault error
On 04-10-20, 21:55, Dave Jiang wrote:
> > > +static bool process_fault(struct idxd_desc *desc, u64 fault_addr)
> > > +{
> > > + if ((u64)desc->hw == fault_addr ||
> > > + (u64)desc->completion == fault_addr) {
> >
> > you are casting descriptor address and completion, I can understand
> > former, but later..? Can you explain this please
> >
>
> It is possible to fail on the completion writeback address if the completion
> address programmed into the descriptor is bad.

Okay thanks for clarifying, maybe would help to add a comment.

--
~Vinod

\
 
 \ /
  Last update: 2020-10-05 07:47    [W:0.042 / U:3.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site