[lkml]   [2020]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 2/2] media: mtk-vcodec: fix build breakage when one of VPU or SCP is enabled
On Tue, Oct 13, 2020 at 9:44 PM Alexandre Courbot <> wrote:
> The addition of MT8183 support added a dependency on the SCP remoteproc
> module. However the initial patch used the "select" Kconfig directive,
> which may result in the SCP module to not be compiled if remoteproc was
> disabled. In such a case, mtk-vcodec would try to link against
> non-existent SCP symbols. "select" was clearly misused here as explained
> in kconfig-language.txt.
> Replace this by a "depends" directive on at least one of the VPU and
> SCP modules, to allow the driver to be compiled as long as one of these
> is enabled, and adapt the code to support this new scenario.
> Also adapt the Kconfig text to explain the extra requirements for MT8173
> and MT8183.
> Reported-by: Sakari Ailus <>
> Signed-off-by: Alexandre Courbot <>

Fixes: bf1d556ad4e0 ("media: mtk-vcodec: abstract firmware interface")

 \ /
  Last update: 2020-10-30 11:19    [W:0.115 / U:3.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site