lkml.org 
[lkml]   [2020]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 0/7] gpio: exar: refactor the driver
On Mon, Oct 26, 2020 at 4:46 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Mon, Oct 26, 2020 at 4:22 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > I just wanted to convert the driver to using simpler IDA API but ended up
> > quickly converting it to using regmap. Unfortunately I don't have the HW
> > to test it so marking the patches that introduce functional change as RFT
> > and Cc'ing the original author.
>
> +Cc: Jan, AFAIR their devices are using Exar UART.

From code perspective looks good to me, FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

(One nit to one patch, but I think it should be fine)

> > Bartosz Golaszewski (7):
> > gpio: exar: add a newline after the copyright notice
> > gpio: exar: include idr.h
> > gpio: exar: switch to a simpler IDA interface
> > gpio: exar: use a helper variable for &pdev->dev
> > gpio: exar: unduplicate address and offset computation
> > gpio: exar: switch to using regmap
> > gpio: exar: use devm action for freeing the IDA and drop remove()


--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-10-26 16:05    [W:0.133 / U:2.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site