[lkml]   [2020]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mm/util.c: Add error logs for commitment overflow
On 2020-10-02 17:41, Matthew Wilcox wrote:

> I don't think the __func__ is particularly useful information. I would
> also expect the name of the process to be more interesting than the
> PID.
> And why is the ppid useful?

Dear Matthew, First, thank you so much for your review and comments.
I totally agree with you.
Yes, initially I included process-name but later removed it to shrink
some lines.
I thought just pid should be enough to figure out the culprit process
from dumps.
Okay, I agree __func__ can also be removed.
ppid, I thought might be useful, so I included it. Okay I will remove
that too.

> Wouldn't this message be more useful?
> fork: Would overcommit system (pid:162 name:./consume-and-fork.out)

Okay, yes I think this should be sufficient.
But I think printing pages also should be good to indicate the users to
information about this commitment.

> ie put it in dup_mmap() and use current->comm

Sorry, this part about dup_mmap(), I could not understand.


 \ /
  Last update: 2020-10-02 18:18    [W:0.090 / U:4.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site