lkml.org 
[lkml]   [2020]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver
From
Date

>>> +/* Setup PLL clock as per the given sample rate */
>>> +static int tegra_audio_graph_update_pll(struct snd_pcm_substream *substream,
>>> + struct snd_pcm_hw_params *params)
>>> +{
>>> + struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
>>> + struct asoc_simple_priv *priv = snd_soc_card_get_drvdata(rtd->card);
>>> + struct device *dev = rtd->card->dev;
>>> + struct tegra_audio_graph_data *graph_data =
>>> + (struct tegra_audio_graph_data *)priv->data;
>>> + struct tegra_audio_chip_data *chip_data =
>>> + (struct tegra_audio_chip_data *)of_device_get_match_data(dev);
>> void* doesn't need casting
>>
> There are several similar places in the code. Not a big deal, but this
> makes code less readable than it could be.

I will drop these in next revision.

\
 
 \ /
  Last update: 2020-10-02 10:52    [W:0.070 / U:22.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site