lkml.org 
[lkml]   [2020]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 11/14] misc: bcm-vk: add BCM_VK_QSTATS
From
Date


On 10/2/2020 2:23 PM, Scott Branden wrote:
> Add BCM_VK_QSTATS Kconfig option to allow for enabling debug VK
> queue statistics.
>
> These statistics keep track of max, abs_max, and average for the
> messages queues.
>
> Co-developed-by: Desmond Yan <desmond.yan@broadcom.com>
> Signed-off-by: Desmond Yan <desmond.yan@broadcom.com>
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>

would not it make more sense to have those debug prints be trace printks
instead? Given what you explained in the previous patch version and the
desire to correlate with other system wide activity, that might make
more sense. Looking at the kernel's log for debugging performance or
utilization or just to get a glimpse of what is going on is not quite
suited past probe.
--
Florian

\
 
 \ /
  Last update: 2020-10-03 03:40    [W:0.076 / U:6.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site