lkml.org 
[lkml]   [2020]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][next] block: scsi_ioctl: Avoid the use of one-element arrays
On Fri, Oct 02, 2020 at 05:58:33PM -0600, Jens Axboe wrote:
> >>> - void __user *reserved[1]; /* unused, actually */
> >>> + union {
> >>> + void __user *reserved[1]; /* unused, actually */
> >>> + void __user *unused;
> >>> + };
> >>
> >> What's the point of this union, why not just turn it into
> >>
> >> void * __user *unused;
> >>
> >> ?
> >
> > I just don't want to take any chances of breaking any user-space
> > application that, for some reason, may be considering that field.
>
> I guess that's a valid concern, who knows what applications are doing
> to an ignored field.
>
> I'll apply it, thanks.

Awesome. :)

Thanks.
--
Gustavo

\
 
 \ /
  Last update: 2020-10-03 02:02    [W:0.032 / U:4.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site